linux-mips
[Top] [All Lists]

Re: [PATCH 3/6] MIPS: Add support for the proAptiv cores

To: Markos Chandras <markos.chandras@imgtec.com>
Subject: Re: [PATCH 3/6] MIPS: Add support for the proAptiv cores
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 11 Nov 2013 11:59:08 -0800
Cc: linux-mips@linux-mips.org, Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=nA5jmUHVwmN1fdLP1L8HpUmCupYIqfK1dkTL/4pS2rs=; b=LdBM0TKAGH+GB0+3GXjp+FU1iupg7UJHm+cErD5DYm164f0sBwcCPcuzl/Xku+kt6S nOMK6OgYL7LxKBfwFyb7kbp1wrM7MNIFDaLJOEiP2Ms7m5w3PhWeQbfumKBw3EdIJAkP PgUWnU0vwqHQGszrHCSdB9BNT+3L+dxEgAtqtjJvcprX1WhyYa8OmNuGWlbaBEOZaXxp d9b9qc9HYRbgWdr4jaVDSvUNXeGqHCBZA6UvDs/+IhzHOrXBhG86uNagb80tBXrgq7d3 jGC9xzn0BfvtllXXOPpsgHy9A21H92AZphu3PhI04EFuzT5zDS3DU9cn6wHd1tSVHvlQ Fsvw==
In-reply-to: <1383844120-29601-4-git-send-email-markos.chandras@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1383844120-29601-1-git-send-email-markos.chandras@imgtec.com> <1383844120-29601-4-git-send-email-markos.chandras@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 11/07/2013 09:08 AM, Markos Chandras wrote:
From: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>

The proAptiv Multiprocessing System is a power efficient multi-core
microprocessor for use in system-on-chip (SoC) applications.
The proAptiv Multiprocessing System combines a deep pipeline
with multi-issue out of order execution for improved computational
throughput. The proAptiv Multiprocessing System can contain one to
six MIPS32r3 proAptiv cores, system level coherence
manager with L2 cache, optional coherent I/O port, and optional
floating point unit.

Reviewed-by: Paul Burton <paul.burton@imgtec.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
Signed-off-by: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>


This patch is a big collection of small unrelated changes.

Can you break it up so that there is one patch per change?

o Add new identifiers
o Probe for them.
o Add new cpu-features.
o tlb.h change.
o All the places you add 'case CPU_PROAPTIV'

Plus...
---
  arch/mips/include/asm/cpu-features.h |  3 +++
  arch/mips/include/asm/cpu-type.h     |  1 +
  arch/mips/include/asm/cpu.h          |  5 ++++-
  arch/mips/include/asm/tlb.h          |  4 +++-
  arch/mips/kernel/cpu-probe.c         | 15 +++++++++++++++
  arch/mips/kernel/idle.c              |  1 +
  arch/mips/kernel/spram.c             |  1 +
  arch/mips/kernel/traps.c             |  1 +
  arch/mips/mm/c-r4k.c                 |  1 +
  arch/mips/mm/sc-mips.c               |  1 +
  arch/mips/mm/tlbex.c                 |  1 +
  arch/mips/oprofile/op_model_mipsxx.c |  4 ++++
  12 files changed, 36 insertions(+), 2 deletions(-)

[...]
diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
index c814287..8168e29 100644
--- a/arch/mips/kernel/cpu-probe.c
+++ b/arch/mips/kernel/cpu-probe.c
@@ -286,6 +286,13 @@ static inline unsigned int decode_config4(struct 
cpuinfo_mips *c)
            && cpu_has_tlb)
                c->tlbsize += (config4 & MIPS_CONF4_MMUSIZEEXT) * 0x40;

+       if (cpu_has_tlb) {
+               if (((config4 & MIPS_CONF4_IE) >> 29) == 2) {
+                       c->options |= MIPS_CPU_TLBINV;
+                       pr_info("TLBINV/F supported, config4=0x%0x\n", config4);

... The probing functions don't print messages, so don't add this pr_info().


+               }
+       }
+


<Prev in Thread] Current Thread [Next in Thread>