linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: ralink: fix return value check in rt_timer_probe()

To: Wei Yongjun <weiyj.lk@gmail.com>
Subject: Re: [PATCH] MIPS: ralink: fix return value check in rt_timer_probe()
From: John Crispin <blogic@openwrt.org>
Date: Thu, 31 Oct 2013 10:52:17 +0100
Cc: ralf@linux-mips.org, grant.likely@linaro.org, rob.herring@calxeda.com, yongjun_wei@trendmicro.com.cn, linux-mips@linux-mips.org
In-reply-to: <CAPgLHd81Ucjnc=pmdxiZzBrk15ui1ezyowdd8JxYzvmmdLoMwQ@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <CAPgLHd81Ucjnc=pmdxiZzBrk15ui1ezyowdd8JxYzvmmdLoMwQ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
On 31/10/13 08:51, Wei Yongjun wrote:
From: Wei Yongjun<yongjun_wei@trendmicro.com.cn>

In case of error, the function devm_request_and_ioremap() returns NULL
pointer not ERR_PTR(). Fix it by using devm_ioremap_resource() instead
of devm_request_and_ioremap().

Signed-off-by: Wei Yongjun<yongjun_wei@trendmicro.com.cn>
Thanks for spotting the bug.

Acked-by: John Crispin <blogic@openwrt.org>



<Prev in Thread] Current Thread [Next in Thread>