linux-mips
[Top] [All Lists]

Re: [PATCH mips-for-linux-next] MIPS: fix genex.S build for non MIPS32r2

To: Florian Fainelli <f.fainelli@gmail.com>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH mips-for-linux-next] MIPS: fix genex.S build for non MIPS32r2 class processors
From: Markos Chandras <Markos.Chandras@imgtec.com>
Date: Mon, 28 Oct 2013 14:36:35 +0000
Cc: <ralf@linux-mips.org>, <blogic@openwrt.org>, <Leonid.Yegoshin@imgtec.com>, <jim2101024@gmail.com>
In-reply-to: <1382725617-32561-1-git-send-email-f.fainelli@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1382725617-32561-1-git-send-email-f.fainelli@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
On 25/10/2013 07:26 μμ, Florian Fainelli wrote:
Commit d712357d ("MIPS: Print correct PC in trace dump after NMI
exception") introduced assembly code which uses the "ehb" instruction,
which is only available in MIPS32r2 class processors and causes such
build errors on MIPS32r1 processors:

   AS      arch/mips/kernel/genex.o
arch/mips/kernel/genex.S: Assembler messages:
arch/mips/kernel/genex.S:386: Error: opcode not supported on this
processor: mips32 (mips32) `ehb'
make[2]: *** [arch/mips/kernel/genex.o] Error 1
make[1]: *** [arch/mips/kernel] Error 2
make[1]: *** Waiting for unfinished jobs....

Use _ehb which properly substitutes to a nop or a real ehb depending on
the processor we are building for.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---

Yep that looks good to me. Thanks for fixing it

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>

--
markos


<Prev in Thread] Current Thread [Next in Thread>