linux-mips
[Top] [All Lists]

Re: [PATCH] UPROBES: Remove useless __weak attribute

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] UPROBES: Remove useless __weak attribute
From: David Daney <ddaney.cavm@gmail.com>
Date: Fri, 11 Oct 2013 15:06:57 -0700
Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>, Oleg Nesterov <oleg@redhat.com>, Anton Arapov <anton@redhat.com>, Ananth N Mavinakayanahalli <ananth@in.ibm.com>, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=F6ZarSfOMrr+muZwHtWnAUmKsxTDUDLnRHo7fb8EGP0=; b=cu1RF3jnNNhlFZxsRJBhj2ezBG7Pvn4lAcwXg2HBRyxTo4J2pfyJhJHjKjG9bkWBZM RqbUNmvMitSbcUEECePG5jQsUgrlbWj5+tIUNMGS8zl8YP9/fW4SvKSh1cmuLK+bB2sf 5J+aGs0wrZRX/X+Ug+cbGRQ34hQijbzWF8fTC2uPPsCXKi1TRxUSnajrhwD0NckCfb9K kJpYsUlqQt1/fI5/E7TaIy2xKZHiaMDyjIAI0ACpwtOlHmk3LEQeDoqcpj0VVwRj6QBA Nr5twPDffyI/A2fSCtzvBVjP6EaNHgBFQSgxYVKjUaFbtJNKTxTjXzeQD+XXzu8oTzdC SoKQ==
In-reply-to: <20131011122407.GO1615@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20131009120809.GN1615@linux-mips.org> <20131011005128.GA2199@linux.vnet.ibm.com> <20131011122407.GO1615@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 10/11/2013 05:24 AM, Ralf Baechle wrote:
On Fri, Oct 11, 2013 at 06:21:28AM +0530, Srikar Dronamraju wrote:

Will be nice to have another arch(mips) support for uprobes.

It's basically ready to be merged - but it's triggering issues elsewhere
in the kernel which I have to resolve first.

The short version is that the memory special mapping created by uprobe
with VM_EXEC but not VM_READ permissions is not working but it's working
if I add VM_READ.  That should not be necessary so something deep down
in the guts of arch/mips is wrong.


Weird, I have a testcase that explicitly tests VM_EXEC and !VM_READ that works.

Do you have more information about the failure, I can look at it in the simulator and see where it goes wrong.

Thanks,
David Daney


<Prev in Thread] Current Thread [Next in Thread>