linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: SmartMIPS: Fix build

To: Markos Chandras <Markos.Chandras@imgtec.com>
Subject: Re: [PATCH] MIPS: SmartMIPS: Fix build
From: Ralf Baechle <ralf@linux-mips.org>
Date: Mon, 7 Oct 2013 17:58:05 +0200
Cc: Thierry Reding <thierry.reding@gmail.com>, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
In-reply-to: <5252D343.6090100@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1381158642-10598-1-git-send-email-treding@nvidia.com> <5252D343.6090100@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Oct 07, 2013 at 04:29:07PM +0100, Markos Chandras wrote:

> On 10/07/13 16:10, Thierry Reding wrote:
> >All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but
> >the ACX register declaration in struct pt_regs is still protected by it,
> >causing builds to fail. Remove the #ifdef protection and always declare
> >the register.
> >
> >Signed-off-by: Thierry Reding <treding@nvidia.com>
> >---
> >  arch/mips/include/asm/ptrace.h | 2 --
> >  1 file changed, 2 deletions(-)
> >
> >diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
> >index 7bba9da..d47bdce 100644
> >--- a/arch/mips/include/asm/ptrace.h
> >+++ b/arch/mips/include/asm/ptrace.h
> >@@ -33,9 +33,7 @@ struct pt_regs {
> >     unsigned long cp0_status;
> >     unsigned long hi;
> >     unsigned long lo;
> >-#ifdef CONFIG_CPU_HAS_SMARTMIPS
> >     unsigned long acx;
> >-#endif
> >     unsigned long cp0_badvaddr;
> >     unsigned long cp0_cause;
> >     unsigned long cp0_epc;
> >
> 
> Hi Thierry,
> 
> Looks good to me. Thanks!
> 
> Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>

Looking good - but I've already pulled the offending patch.  Processor
specific registers in the register frame have historically been a PITA -
in particular because much of what's requiring space there is also
requiring space in the signal frame and that's a kernel ABI.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>