linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: SmartMIPS: Fix build

To: Thierry Reding <thierry.reding@gmail.com>, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: SmartMIPS: Fix build
From: Markos Chandras <Markos.Chandras@imgtec.com>
Date: Mon, 7 Oct 2013 16:29:07 +0100
Cc: <linux-mips@linux-mips.org>, <linux-kernel@vger.kernel.org>
In-reply-to: <1381158642-10598-1-git-send-email-treding@nvidia.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1381158642-10598-1-git-send-email-treding@nvidia.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0
On 10/07/13 16:10, Thierry Reding wrote:
All CONFIG_CPU_HAS_SMARTMIPS #ifdefs have been removed from code, but
the ACX register declaration in struct pt_regs is still protected by it,
causing builds to fail. Remove the #ifdef protection and always declare
the register.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
  arch/mips/include/asm/ptrace.h | 2 --
  1 file changed, 2 deletions(-)

diff --git a/arch/mips/include/asm/ptrace.h b/arch/mips/include/asm/ptrace.h
index 7bba9da..d47bdce 100644
--- a/arch/mips/include/asm/ptrace.h
+++ b/arch/mips/include/asm/ptrace.h
@@ -33,9 +33,7 @@ struct pt_regs {
        unsigned long cp0_status;
        unsigned long hi;
        unsigned long lo;
-#ifdef CONFIG_CPU_HAS_SMARTMIPS
        unsigned long acx;
-#endif
        unsigned long cp0_badvaddr;
        unsigned long cp0_cause;
        unsigned long cp0_epc;


Hi Thierry,

Looks good to me. Thanks!

Reviewed-by: Markos Chandras <markos.chandras@imgtec.com>


<Prev in Thread] Current Thread [Next in Thread>