linux-mips
[Top] [All Lists]

Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs(

To: Jon Mason <jon.mason@intel.com>
Subject: Re: [PATCH RFC 01/77] PCI/MSI: Fix return value when populate_msi_sysfs() failed
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Thu, 3 Oct 2013 22:46:21 +0100
Cc: Alexander Gordeev <agordeev@redhat.com>, <linux-kernel@vger.kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Ralf Baechle <ralf@linux-mips.org>, Michael Ellerman <michael@ellerman.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Martin Schwidefsky <schwidefsky@de.ibm.com>, "Ingo Molnar" <mingo@redhat.com>, Tejun Heo <tj@kernel.org>, Dan Williams <dan.j.williams@intel.com>, Andy King <acking@vmware.com>, Matt Porter <mporter@kernel.crashing.org>, <stable@vger.kernel.org>, <linux-pci@vger.kernel.org>, <linux-mips@linux-mips.org>, <linuxppc-dev@lists.ozlabs.org>, <linux390@de.ibm.com>, <linux-s390@vger.kernel.org>, <x86@kernel.org>, <linux-ide@vger.kernel.org>, <iss_storagedev@hp.com>, <linux-nvme@lists.infradead.org>, <linux-rdma@vger.kernel.org>, <netdev@vger.kernel.org>, <e1000-devel@lists.sourceforge.net>, <linux-driver@qlogic.com>, "Solarflare linux maintainers" <linux-net-drivers@solarflare.com>, "VMware, Inc." <pv-drivers@vmware.com>, <linux-scsi@vger.kernel.org>
In-reply-to: <20131003003905.GK6768@jonmason-lab>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: Solarflare
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <cover.1380703262.git.agordeev@redhat.com> <3ff5236944aae69f2cd934b5b6da7c1c269df7c1.1380703262.git.agordeev@redhat.com> <20131003003905.GK6768@jonmason-lab>
Sender: linux-mips-bounce@linux-mips.org
On Wed, 2013-10-02 at 17:39 -0700, Jon Mason wrote:
> On Wed, Oct 02, 2013 at 12:48:17PM +0200, Alexander Gordeev wrote:
> > Signed-off-by: Alexander Gordeev <agordeev@redhat.com>
> 
> Since you are changing the behavior of the msix_capability_init
> function on populate_msi_sysfs error, a comment describing why in this
> commit would be nice.
[...]

This function was already treating that error as fatal, and freeing the
MSIs.  The change in behaviour is that it now returns the error code in
this case, rather than 0.  This is obviously correct and properly
described by the one-line summary.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


<Prev in Thread] Current Thread [Next in Thread>