linux-mips
[Top] [All Lists]

Re: Linux 3.12-rc2 - MIPS regression

To: Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: Linux 3.12-rc2 - MIPS regression
From: Yoichi Yuasa <yuasa@linux-mips.org>
Date: Tue, 1 Oct 2013 14:24:21 +0900
Cc: yuasa@linux-mips.org, Linus Torvalds <torvalds@linux-foundation.org>, Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
In-reply-to: <20130927231012.GB4572@blackmetal.musicnaut.iki.fi>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <CA+55aFxoF75RJfkp0vnm-b9B0h7PGMitrQiLyTt315tKvG-wTQ@mail.gmail.com> <20130927231012.GB4572@blackmetal.musicnaut.iki.fi>
Sender: linux-mips-bounce@linux-mips.org
Hi,

On Sat, 28 Sep 2013 02:10:12 +0300
Aaro Koskinen <aaro.koskinen@iki.fi> wrote:

> Hi,
> 
> 3.12-rc2 breaks the boot (BUG: scheduling while atomic, see logs below)
> on Lemote Mini-PC (MIPS). According to git bisect, this is caused by:
> 
> ff522058bd717506b2fa066fa564657f2b86477e is the first bad commit
> commit ff522058bd717506b2fa066fa564657f2b86477e
> Author: Ralf Baechle <ralf@linux-mips.org>
> Date:   Tue Sep 17 12:44:31 2013 +0200
> 
>     MIPS: Fix accessing to per-cpu data when flushing the cache
> 
> Reverting the commit from v3.12-rc2 makes the board boot fine.

Please try this patch on top of rc2.

MIPS: Fix forgotten preempt_enable() when CPU has inclusive pcaches

Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>

diff --git a/arch/mips/mm/c-r4k.c b/arch/mips/mm/c-r4k.c
index 627883b..2492e60 100644
--- a/arch/mips/mm/c-r4k.c
+++ b/arch/mips/mm/c-r4k.c
@@ -609,6 +609,7 @@ static void r4k_dma_cache_wback_inv(unsigned long addr, 
unsigned long size)
                        r4k_blast_scache();
                else
                        blast_scache_range(addr, addr + size);
+               preempt_enable();
                __sync();
                return;
        }

<Prev in Thread] Current Thread [Next in Thread>