[Top] [All Lists]

Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is spe

To: David Daney <>
Subject: Re: [PATCH 1/2] staging: octeon-ethernet: don't assume that CPU 0 is special
From: Aaro Koskinen <>
Date: Tue, 1 Oct 2013 00:27:08 +0300
Cc:,, David Daney <>,, Greg Kroah-Hartman <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <> <> <> <>
User-agent: Mutt/1.5.21 (2010-09-15)

On Mon, Sep 30, 2013 at 02:08:31PM -0700, David Daney wrote:
> On 09/30/2013 12:56 PM, Aaro Koskinen wrote:
> >What guarantees that CPU0 is around (or the smp_affinity is at its
> >default value) by the time user executes modprobe?
> Nothing enforced by the kernel.  Just don't take CPU0 off-line and
> you should be good to go.
> There is a lot of room for improvement in the driver.
> Really this whole thing of starting NAPI on multiple CPUs for the
> same input queue is not good.  It leads to loss of packet ordering
> when forwarding.

I agree. I have also another patch which deletes this functionality
altogether - should I post that one instead? In modern kernel you can use
RPS to steer packets to different cores/softirqs threads, so in a way the
driver currently duplicates some of the generic kernel functionality...


<Prev in Thread] Current Thread [Next in Thread>