[Top] [All Lists]

Re: Issue with BUG() in asm-gemeric/bug.h if CONFIG_BUG=n

To: David Daney <>
Subject: Re: Issue with BUG() in asm-gemeric/bug.h if CONFIG_BUG=n
From: Geert Uytterhoeven <>
Date: Mon, 30 Sep 2013 21:03:28 +0200
Cc: "Pinski, Andrew" <>, Ralf Baechle <>, "" <>, Arnd Bergmann <>, David Howells <>, Markos Chandras <>, "" <>, John Crispin <>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=6rNZKnhnbyhXwg3Bx1f10d/tJYLL3TJSYyyzYaDBRzg=; b=sx9/SM+d2jYmk0jvK0aH3cvNgwhKUs0EmK8u3ZUOsmIsgml0JXlkEb4aU1nHWUuuGK st5TSM+W0C1/5/OLrCeeqeUNsoP89VCAz5Svi3Xgg+25uOKiG7Xq14vWj7dijJ+v3gmx kLQUHDMemC4gk8mB4nq05mn7VfNTrjksF0powE9wPdv7CZS95MulpDBYX1hJnRWkuPkw N5qaazzz3lqfyFbHm5/XzdsiDZ4GMQzbeOwpeNbRqAGaUnbaHHxY+aiI88M6QruqBIhc bN/7tL8YETfKqegMOLt3/BePiRkzph3yvrE0t2H+godUB+WUhaTodcCfogT/gYeQ5xP9 P2DQ==
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <> <>
On Mon, Sep 30, 2013 at 7:45 PM, David Daney <> wrote:
>> What about using __builtin_unreachable when we can but turn off warnings
>> and use do{}while(0) when __builtin_unreachable does not exist?  This seems
>> the both worlds.  Newer compilers produce better code with unreachable
>> anyways.
> Simply not true.
> do{}while(0) is a NOP it is no more useful than an ';' statement.  It
> doesn't serve as a magic uninitialized variable hiding mechanism.

You missed the "turn off warnings" part of the "and".



Geert Uytterhoeven -- There's lots of Linux beyond ia32 --

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>