linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: kernel: traps: Remove useless BUG_ON()

To: Markos Chandras <markos.chandras@imgtec.com>
Subject: Re: [PATCH] MIPS: kernel: traps: Remove useless BUG_ON()
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 27 Sep 2013 14:43:04 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <20130926160822.GD31496@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1380188131-28792-1-git-send-email-markos.chandras@imgtec.com> <20130926160822.GD31496@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 26, 2013 at 06:08:22PM +0200, Ralf Baechle wrote:

> In any case that could have broken PowerTV which does the following:
> 
>         if (cpu_has_veic || cpu_has_vint) {
>                 int nvec = cpu_has_veic ? 64 : 8;
>                 for (i = 0; i < nvec; i++)
>                         set_vi_handler(i, asic_irqdispatch);
>         }
> 
> Nobody from PowerTV complained.  Time to sharpen the axe!

Ok…  Of course it didn't break PowerTV - but I was getting pretty
triggerhappy about that platform anyway.

So while I've queued the patch to remove PowerTV support, I'm more than
happy to remove it again if somebody shows up and promises to test and
take care of the platform.  And such threats seem to work most efficient
with the proper patch bomb attached.

That of course doesn't affect your patch which I'm going to apply.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>