linux-mips
[Top] [All Lists]

Re: [PATCH 2/8] um: Do not use SUBARCH

To: Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH 2/8] um: Do not use SUBARCH
From: Ramkumar Ramachandra <artagnon@gmail.com>
Date: Thu, 26 Sep 2013 18:43:16 +0530
Cc: linux-arch@vger.kernel.org, Michal Marek <mmarek@suse.cz>, geert@linux-m68k.org, ralf@linux-mips.org, lethal@linux-sh.org, Jeff Dike <jdike@addtoit.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org, linux-kbuild@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, linux-sh@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=iio4Rr30IHGThubCmiGm13OO3dbs/OvbpdMbc+ORgaI=; b=zKxodCWv0rUGoBJdzOKpT1M9q+TezC6N4UacKpJtvs5IaTKGieGQka7Dz9jxThlheZ h8e1sUvki1YSMRyYZoc08qQXG38VptD8bl+zhwH3I3PvSxEcV9lxrGInKAMnPzYwIMgF tX35YmVXy3h3a1VUj7inAmE7Modt2sCCxk44sxLftb7KAtu08QxOGxQq0k6z4qeD2amg CrHo4M4uIZXEuqyAwCH1qYt4tJQraw0bj3uYY5tsrZMvffbOFLDdYZmmOQjYTrpsFr9m moIIPW8+cGuYwAjFkbxyhv7TfRz5QODQjwjVnbetIZ8C1mIb5GKwPswfnzD3Ik815AGR XPKQ==
In-reply-to: <CALkWK0nm=9n7DiV0MaGKVLMs=vxAiiQUx=OFuOg-DinkdMej5A@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1377073172-3662-1-git-send-email-richard@nod.at> <1377073172-3662-3-git-send-email-richard@nod.at> <CALkWK0kCrQ9hPABD_XQ9QFG-vByP+xZWZs+RkVK77+cX7Odz7g@mail.gmail.com> <52441025.9030308@nod.at> <CALkWK0k5neR50h+AWEF5AgnpbgWMitZUnbv_caVzt6HiUA6mXg@mail.gmail.com> <52441407.9010603@nod.at> <CALkWK0=FG4COEjv5+mu1JRiiFQ2k6vop1mhFPmAT4bjtYeK6nA@mail.gmail.com> <52442108.1020304@nod.at> <CALkWK0nm=9n7DiV0MaGKVLMs=vxAiiQUx=OFuOg-DinkdMej5A@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
Ramkumar Ramachandra wrote:
> Richard Weinberger wrote:
>> I told you already that "make defconfig ARCH=um SUBARCH=x86" will spuriously
>> create a x86_64 config on x86_64.
>> This breaks existing setups.
>
> I'll fix this and resubmit soon.

Wait a minute. You're now arguing about whether the generic "x86"
means i386 or x86_64. Its meaning is already defined in
arch/x86/Kconfig and arch/x86/um/Kconfig: see the config 64BIT. Unless
i386 is explicitly specified, the default is to build a 64-bit kernel.
That is already defined for a normal Linux kernel, and user-mode Linux
should not break that convention. So, in the example you pulled out of
your hat:

  $ make defconfig ARCH=um SUBARCH=x86

the user should expect a 64-bit build, and not an i386 build as you
say. Both my patches are correct, and the "regression" that you
pointed out is a red herring.

<Prev in Thread] Current Thread [Next in Thread>