linux-mips
[Top] [All Lists]

Re: [PATCH V12 00/13] MIPS: Add Loongson-3 based machines support

To: Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH V12 00/13] MIPS: Add Loongson-3 based machines support
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 26 Sep 2013 14:45:36 +0200
Cc: John Crispin <john@phrozen.org>, linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>, Zhangjin Wu <wuzhangjin@gmail.com>, Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>
In-reply-to: <1380100546-8302-1-git-send-email-chenhc@lemote.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1380100546-8302-1-git-send-email-chenhc@lemote.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 25, 2013 at 05:15:34PM +0800, Huacai Chen wrote:

Generally this patchset is still adding an eyewatering number of
#ifdef CONFIG_CPU_LOONGSON2/3s to the code.  What we had in the existing
code base was already ugly.  So I just went through arch/mips removing
many of the existing ifdefs.

Will push that out to upstream-sfr a little later this afternoon.

This means, your patchset is not going to apply cleanly anymore!

Also I'm wondering about these two uses of CONFIG_CPU_LOONGSON2:

arch/mips/mm/tlbex.c:#if defined(CONFIG_32BIT) || defined(CONFIG_CPU_LOONGSON2)
arch/mips/mm/tlbex.c:#if defined(CONFIG_32BIT) || defined(CONFIG_CPU_LOONGSON2)

Why would we want to treat a Loongson2 - a 64 bit CPU after all - as a 32 bit
CPU?  Can you explain?

Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>