[Top] [All Lists]

Re: [PATCH V12 00/13] MIPS: Add Loongson-3 based machines support

To: Huacai Chen <>
Subject: Re: [PATCH V12 00/13] MIPS: Add Loongson-3 based machines support
From: Ralf Baechle <>
Date: Thu, 26 Sep 2013 14:45:36 +0200
Cc: John Crispin <>,, Fuxin Zhang <>, Zhangjin Wu <>, Hongliang Tao <>, Hua Yan <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 25, 2013 at 05:15:34PM +0800, Huacai Chen wrote:

Generally this patchset is still adding an eyewatering number of
#ifdef CONFIG_CPU_LOONGSON2/3s to the code.  What we had in the existing
code base was already ugly.  So I just went through arch/mips removing
many of the existing ifdefs.

Will push that out to upstream-sfr a little later this afternoon.

This means, your patchset is not going to apply cleanly anymore!

Also I'm wondering about these two uses of CONFIG_CPU_LOONGSON2:

arch/mips/mm/tlbex.c:#if defined(CONFIG_32BIT) || defined(CONFIG_CPU_LOONGSON2)
arch/mips/mm/tlbex.c:#if defined(CONFIG_32BIT) || defined(CONFIG_CPU_LOONGSON2)

Why would we want to treat a Loongson2 - a 64 bit CPU after all - as a 32 bit
CPU?  Can you explain?



<Prev in Thread] Current Thread [Next in Thread>