linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: BCM47XX: add EARLY_PRINTK_8250 support

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH 2/2] MIPS: BCM47XX: add EARLY_PRINTK_8250 support
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Fri, 20 Sep 2013 02:08:16 +0400
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <1379627091-30769-2-git-send-email-hauke@hauke-m.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: Cogent Embedded
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1379627091-30769-1-git-send-email-hauke@hauke-m.de> <1379627091-30769-2-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
Hello.

On 09/20/2013 01:44 AM, Hauke Mehrtens wrote:

The BCM47xx SoCs have a 8250 serial compatible console at address
0xb8000300 and an other at 0xb8000400. On most devices 0xb8000300 is
wired to some pins on the board, we should use that.

   I think these are KSEG1 virtual addresses, not physical.

Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
---
  arch/mips/Kconfig        |    2 ++
  arch/mips/bcm47xx/prom.c |    1 +
  2 files changed, 3 insertions(+)

[...]
diff --git a/arch/mips/bcm47xx/prom.c b/arch/mips/bcm47xx/prom.c
index 99c3ce2..26f49f8 100644
--- a/arch/mips/bcm47xx/prom.c
+++ b/arch/mips/bcm47xx/prom.c
@@ -97,6 +97,7 @@ static __init void prom_init_mem(void)
  void __init prom_init(void)
  {
        prom_init_mem();
+       setup_8250_early_printk_port(CKSEG1ADDR(0xb8000300), 0, 0);

   Applying CKSEG1ADDR() to virtual address is wrong.

WBR, Sergei


<Prev in Thread] Current Thread [Next in Thread>