linux-mips
[Top] [All Lists]

[PATCH 1/10] MIPS: BCM47XX: Cocci spatch "noderef"

To: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/10] MIPS: BCM47XX: Cocci spatch "noderef"
From: thomas@m3y3r.de Thu Sep 19 17:31:10 2013
Date: Thu, 19 Sep 2013 20:38:21 +0200
In-reply-to: <1379604755850-858421494-0-diffsplit-thomas@m3y3r.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1379604755850-858421494-0-diffsplit-thomas@m3y3r.de>
Sender: linux-mips-bounce@linux-mips.org
sizeof when applied to a pointer typed expression gives the size of the
pointer.
Found by coccinelle spatch "misc/noderef.cocci"

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/arch/mips/bcm47xx/sprom.c b/arch/mips/bcm47xx/sprom.c
--- a/arch/mips/bcm47xx/sprom.c
+++ b/arch/mips/bcm47xx/sprom.c
@@ -162,7 +162,7 @@ static void nvram_read_alpha2(const char
                pr_warn("alpha2 is too long %s\n", buf);
                return;
        }
-       memcpy(val, buf, sizeof(val));
+       memcpy(val, buf, sizeof(*val));
 }
 
 static void bcm47xx_fill_sprom_r1234589(struct ssb_sprom *sprom,

<Prev in Thread] Current Thread [Next in Thread>