linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: pci: pci-bcm1480: Include missing vt.h header

To: Markos Chandras <markos.chandras@imgtec.com>
Subject: Re: [PATCH] MIPS: pci: pci-bcm1480: Include missing vt.h header
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 19 Sep 2013 13:50:40 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <1379582872-5482-1-git-send-email-markos.chandras@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1379582872-5482-1-git-send-email-markos.chandras@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 19, 2013 at 10:27:52AM +0100, Markos Chandras wrote:

> It's needed for the MAX_NR_CONSOLES macro.
> 
> Fixes the following build problem on a randconfig:
> 
> arch/mips/pci/pci-bcm1480.c: In function 'bcm1480_pcibios_init':
> arch/mips/pci/pci-bcm1480.c:261:36: error: 'MAX_NR_CONSOLES'
> undeclared (first use in this function)
> arch/mips/pci/pci-bcm1480.c:261:36: note: each undeclared
> identifier is reported only once for each function it appears in
> make[1]: *** [arch/mips/pci/pci-bcm1480.o] Error 1
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>

I'm wondering if this *really* has to live in the PCI code.  A VGA in
legacy mode should even work with CONFIG_PCI=n, right?

Anyway, applied.  Thanks!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>