linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: BCM47XX: add board detection

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH 1/2] MIPS: BCM47XX: add board detection
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 18 Sep 2013 14:09:14 +0200
Cc: Geert Uytterhoeven <geert@linux-m68k.org>, Linux MIPS Mailing List <linux-mips@linux-mips.org>
In-reply-to: <52399641.4090901@hauke-m.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1379503798-9014-1-git-send-email-hauke@hauke-m.de> <CAMuHMdU8V=96fEb9Vrpb2+TEWiD5L2Gh+3xzY9SBDotP2NaQ=g@mail.gmail.com> <52399641.4090901@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 18, 2013 at 02:02:09PM +0200, Hauke Mehrtens wrote:

> On 09/18/2013 01:41 PM, Geert Uytterhoeven wrote:
> > On Wed, Sep 18, 2013 at 1:29 PM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> >> Detect on which board this code is running based on some nvram
> >> settings. This is needed to start board specific workarounds and
> >> configure the leds and buttons which are on different gpios on every board.
> >>
> >> This patches add some boards we have seen, but there are many more.
> > 
> > Can you please make the board database __initconst, and only retain in 
> > memory
> > a copy of the detected board info?
> > 
> > Gr{oetje,eeting}s,
> > 
> >                         Geert
> > 
> I will change this in a next version of this patch.

I've already queued the first version of the patch so an incremental
patch would be handy.

Thanks,

  Ralf

<Prev in Thread] Current Thread [Next in Thread>