linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: BCM47XX: add board detection

To: Hauke Mehrtens <hauke@hauke-m.de>
Subject: Re: [PATCH 1/2] MIPS: BCM47XX: add board detection
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Wed, 18 Sep 2013 13:41:34 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, Linux MIPS Mailing List <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Pj9sITmYZKnlMUMy9nt4783NJZrAuhGnQLMQWJ2F7Fs=; b=NMVRyeHIgpIGZz5GT7Pus17JOGItEMm72rfZjFh53xtp0Y7RRXLmezXyhVfOr7euuw TyJCuJuD5yfOn3tDp+1Pl+UY8sROU2A3JTR/g1w+EVskH247wZlWYvuERI2/mGGtqC89 gR0n9gH87TkEIz9lq0e5ahiaezcqEidWJl2IltIA2J/w8BKOa+jwc+MWRe3sNuohR7BC EQl9U7rwnlGj/AGoWL9Dv4PPALkpMYuLEdAxadMaWCtBSHPKi03wcUiooz607wfHjm+p mBbfZO032W+RJH2Rkscp+2Z51tFxryhem4+kzZ5uNIoWxEOuY8mKQ/j0hEQJRuRYFOXD jvkg==
In-reply-to: <1379503798-9014-1-git-send-email-hauke@hauke-m.de>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1379503798-9014-1-git-send-email-hauke@hauke-m.de>
Sender: linux-mips-bounce@linux-mips.org
On Wed, Sep 18, 2013 at 1:29 PM, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> Detect on which board this code is running based on some nvram
> settings. This is needed to start board specific workarounds and
> configure the leds and buttons which are on different gpios on every board.
>
> This patches add some boards we have seen, but there are many more.

Can you please make the board database __initconst, and only retain in memory
a copy of the detected board info?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

<Prev in Thread] Current Thread [Next in Thread>