[Top] [All Lists]

Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well

To: Markos Chandras <>
Subject: Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well
From: Ralf Baechle <>
Date: Wed, 18 Sep 2013 13:33:34 +0200
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 18, 2013 at 01:10:53PM +0200, Ralf Baechle wrote:

> > The CMP code is only designed to work with SMP configurations.
> > Fixes multiple build problems on certain randconfigs:
> Applied - but I think the logic here may be backwards from a user's
> perspective.  Shouldn't a user be asked for SMP first, then for
> possible platform suboptions (CMP, VSMP, SMTC) of SMP?

Also the "if SMP" in Kconfig

 config MIPS_CMP
        bool "MIPS CMP framework support"
        depends on SYS_SUPPORTS_MIPS_CMP
+       select SMP
        select SYNC_R4K
        select SYS_SUPPORTS_SMP
        select SYS_SUPPORTS_SCHED_SMT if SMP

now does look a bit silly, doesn't it?  I wonder what the original intention
was, possibly CMP support but only a uniprocessor kernel, that is
MIPS_CMP=y would enable the GIC only, something like that?


<Prev in Thread] Current Thread [Next in Thread>