linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well

To: Markos Chandras <markos.chandras@imgtec.com>
Subject: Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well
From: Ralf Baechle <ralf@linux-mips.org>
Date: Wed, 18 Sep 2013 13:33:34 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <20130918111053.GK22468@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1378460846-961-1-git-send-email-markos.chandras@imgtec.com> <20130918111053.GK22468@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Sep 18, 2013 at 01:10:53PM +0200, Ralf Baechle wrote:

> > The CMP code is only designed to work with SMP configurations.
> > Fixes multiple build problems on certain randconfigs:
> 
> Applied - but I think the logic here may be backwards from a user's
> perspective.  Shouldn't a user be asked for SMP first, then for
> possible platform suboptions (CMP, VSMP, SMTC) of SMP?

Also the "if SMP" in Kconfig

 config MIPS_CMP
        bool "MIPS CMP framework support"
        depends on SYS_SUPPORTS_MIPS_CMP
+       select SMP
        select SYNC_R4K
        select SYS_SUPPORTS_SMP
        select SYS_SUPPORTS_SCHED_SMT if SMP
                                      ^^^^^^

now does look a bit silly, doesn't it?  I wonder what the original intention
was, possibly CMP support but only a uniprocessor kernel, that is
MIPS_CMP=y would enable the GIC only, something like that?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>