linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well
From: Markos Chandras <Markos.Chandras@imgtec.com>
Date: Wed, 18 Sep 2013 12:28:17 +0100
Cc: <linux-mips@linux-mips.org>
In-reply-to: <20130918111053.GK22468@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1378460846-961-1-git-send-email-markos.chandras@imgtec.com> <20130918111053.GK22468@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 09/18/13 12:10, Ralf Baechle wrote:
On Fri, Sep 06, 2013 at 10:47:26AM +0100, Markos Chandras wrote:

The CMP code is only designed to work with SMP configurations.
Fixes multiple build problems on certain randconfigs:

Applied - but I think the logic here may be backwards from a user's
perspective.  Shouldn't a user be asked for SMP first, then for
possible platform suboptions (CMP, VSMP, SMTC) of SMP?

   Ralf

Hi Ralf,

Well, for example, you can have VSMP with or without CMP so CMP is not
another SMP option but rather an "add-on". However, it might be preferred to move the SMP option higher in the menu.


<Prev in Thread] Current Thread [Next in Thread>