linux-mips
[Top] [All Lists]

Re: [PATCH v2] MIPS: GIC: Select R4K counter as fallback.

To: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
Subject: Re: [PATCH v2] MIPS: GIC: Select R4K counter as fallback.
From: Lars-Peter Clausen <lars@metafoo.de>
Date: Fri, 13 Sep 2013 09:52:29 +0200
Cc: "Steven J. Hill" <Steven.Hill@imgtec.com>, linux-mips@linux-mips.org, ralf@linux-mips.org
In-reply-to: <523206B9.6000201@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1378929101-7021-1-git-send-email-Steven.Hill@imgtec.com> <52316D28.5000100@metafoo.de> <523206B9.6000201@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130827 Icedove/17.0.8
On 09/12/2013 08:23 PM, Leonid Yegoshin wrote:
> On 09/12/2013 12:28 AM, Lars-Peter Clausen wrote:
>> On 09/11/2013 09:51 PM, Steven J. Hill wrote:
>>> From: Leonid Yegoshin <Leonid.Yegoshin@imgtec.com>
>>>
>>> If CONFIG_CSRC_GIC is selected and the GIC is not found during
>>> boot, then fallback to the R4K counter gracefully.
>> Is there any reason not to always register the r4k clocksource, no matter
>> whether the gic clocksource is present or not? The timekeeping core of the
>> kernel will make sure to use the best available clocksource based on the
>> clocksource's rating.
>>
>> - Lars
> If you do power saving by switching some core OFF then you should do an
> additional clock sync after core revival.
> GIC is free from that but R4K is not. It was a primary reason for GIC
> clocksource.

Ok, but what I was saying is that there is no need to not register the r4k
clocksource if the gic clocksource is present since the kernel can deal with
multiple registered clocksources just fine. This is not a problem that needs
to be solved in MIPS specific code, if the rating for the clocksources is
set properly the kernel will switch to the gic clocksource as soon as it is
registered and ignore the r4k clocksource. No need to do any reference to
the gic in the r4k clocksource code.

- Lars


<Prev in Thread] Current Thread [Next in Thread>