linux-mips
[Top] [All Lists]

Re: [PATCH v2] MIPS: do not allow building vmlinuz when !ZBOOT

To: Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v2] MIPS: do not allow building vmlinuz when !ZBOOT
From: James Hogan <james.hogan@imgtec.com>
Date: Wed, 11 Sep 2013 12:11:14 +0100
Cc: <linux-mips@linux-mips.org>, <ralf@linux-mips.org>, <blogic@openwrt.org>, <richard@nod.at>
In-reply-to: <1378895688-16641-1-git-send-email-f.fainelli@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1378895688-16641-1-git-send-email-f.fainelli@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
Hi Florian

On 11/09/13 11:34, Florian Fainelli wrote:
> +vmlinuz: FORCE
> +     @echo '   CONFIG_SYS_SUPPORTS_ZBOOT is not enabled'; \
> +     /bin/false

Nit: You don't really need the echo and /bin/false as part of the same
command (i.e. the "; \" at end of echo), but no big deal.

Reviewed-by: James Hogan <james.hogan@imgtec.com>

Cheers
James


<Prev in Thread] Current Thread [Next in Thread>