linux-mips
[Top] [All Lists]

Re: [PATCH v2 2/2] MIPS: KEXEC: Fixes Random crashes while loading crash

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH v2 2/2] MIPS: KEXEC: Fixes Random crashes while loading crashkernel
From: Ralf Baechle <ralf@linux-mips.org>
Date: Fri, 6 Sep 2013 10:00:24 +0200
Cc: Prem Mallappa <prem.mallappa@gmail.com>, linux-mips <linux-mips@linux-mips.org>, Prem Mallappa <pmallappa@caviumnetworks.com>
In-reply-to: <5228CDEF.4010609@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1378317384-9923-1-git-send-email-pmallappa@caviumnetworks.com> <20130905181222.GC11592@linux-mips.org> <5228CDEF.4010609@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Sep 05, 2013 at 11:31:11AM -0700, David Daney wrote:

> >Prem,
> >
> >I only see patch 2/2.  I wonder, has 1/2 been lost in transit or is there
> >only the 2/2 patch?
> >
> 
> V1 of 1/2 didn't need revision, so it can be applied as is:
> 
> http://patchwork.linux-mips.org/patch/5786/

I've done some cosmetic changes.  Formatting with tabs, as per CodingStyle
use

        /*
         *
         */

style comments, not

        /*
        *
        */

And finally use beqz rather than beq $reg, zero.  Anyway, Prem, thanks
for debugging this & patch applied!

  Ralf

<Prev in Thread] Current Thread [Next in Thread>