linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: sead3: Select NEW_LEDS, LEDS_CLASS and I2C symbols
From: Wolfram Sang <wsa@the-dreams.de>
Date: Tue, 3 Sep 2013 16:55:10 +0100
Cc: Markos Chandras <markos.chandras@imgtec.com>, linux-i2c@vger.kernel.org, Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>, linux-leds@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <20130903145839.GA14258@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1378218420-28011-1-git-send-email-markos.chandras@imgtec.com> <20130903145839.GA14258@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Sep 03, 2013 at 04:58:39PM +0200, Ralf Baechle wrote:
> On Tue, Sep 03, 2013 at 03:27:00PM +0100, Markos Chandras wrote:
> 
> > Select NEW_LEDS and LEDS_CLASS since they export symbols
> > needed by leds-sead3.c. Fixes the following build problem:
> > 
> > leds-sead3.c:(.text+0xf0c): undefined
> > reference to `led_classdev_unregister'
> > leds-sead3.c:(.text+0xf18): undefined
> > reference to `led_classdev_unregister'
> > 
> > Also select I2C since it's needed by sead3-pic32-i2c-drv.c
> > Fixes the following build problem:
> > arch/mips/mti-sead3/sead3-pic32-i2c-drv.c:350:2: error:
> > implicit declaration of
> > function 'i2c_add_numbered_adapter'
> 
> You probably should setup a bus like all the other callers of
> i2c_add_numbered_adapter() in drivers/i2c/busses/; similar for the LED
> issue.

The I2C driver should really be in the i2c realm AFAICS. Also, it needs
a few cleanups.

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>