linux-mips
[Top] [All Lists]

Re: [PATCH v2] MIPS: ath79: Avoid using unitialized 'reg' variable

To: Markos Chandras <markos.chandras@imgtec.com>
Subject: Re: [PATCH v2] MIPS: ath79: Avoid using unitialized 'reg' variable
From: Ralf Baechle <ralf@linux-mips.org>
Date: Tue, 3 Sep 2013 15:38:39 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <1377082042-4219-1-git-send-email-markos.chandras@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1377082042-4219-1-git-send-email-markos.chandras@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Aug 21, 2013 at 11:47:22AM +0100, Markos Chandras wrote:

> Fixes the following build error:
> arch/mips/include/asm/mach-ath79/ath79.h:139:20: error: 'reg' may be used
> uninitialized in this function [-Werror=maybe-uninitialized]
> arch/mips/ath79/common.c:62:6: note: 'reg' was declared here
> In file included from arch/mips/ath79/common.c:20:0:
> arch/mips/ath79/common.c: In function 'ath79_device_reset_clear':
> arch/mips/include/asm/mach-ath79/ath79.h:139:20:
> error: 'reg' may be used uninitialized in this function
> [-Werror=maybe-uninitialized]
> arch/mips/ath79/common.c:90:6: note: 'reg' was declared here
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
> Changes since v1:
> http://www.linux-mips.org/archives/linux-mips/2013-08/msg00126.html
> - Remove BUG(). panic() is enough.
> http://www.linux-mips.org/archives/linux-mips/2013-08/msg00133.html
> - Change panic() message to be more accurate.
> http://www.linux-mips.org/archives/linux-mips/2013-08/msg00164.html
> ---
>  arch/mips/ath79/common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/ath79/common.c b/arch/mips/ath79/common.c
> index eb3966c..6d7a9d4 100644
> --- a/arch/mips/ath79/common.c
> +++ b/arch/mips/ath79/common.c
> @@ -75,7 +75,7 @@ void ath79_device_reset_set(u32 mask)
>       else if (soc_is_qca955x())
>               reg = QCA955X_RESET_REG_RESET_MODULE;
>       else
> -             BUG();
> +             panic("Reset register not defined for this SOC");
>  
>       spin_lock_irqsave(&ath79_device_reset_lock, flags);
>       t = ath79_reset_rr(reg);
> @@ -103,7 +103,7 @@ void ath79_device_reset_clear(u32 mask)
>       else if (soc_is_qca955x())
>               reg = QCA955X_RESET_REG_RESET_MODULE;
>       else
> -             BUG();
> +             panic("Reset register not defined for this SOC");
>  
>       spin_lock_irqsave(&ath79_device_reset_lock, flags);
>       t = ath79_reset_rr(reg);

Looks more like the implementation of BUG() is wrong and gcc doesn't
notice that BUG() won't return.

Was this triggered by CONFIG_BUG=n?

  Ralf

<Prev in Thread] Current Thread [Next in Thread>