linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: powertv: Drop BOOTLOADER_DRIVER Kconfig symbol

To: John Crispin <john@phrozen.org>
Subject: Re: [PATCH] MIPS: powertv: Drop BOOTLOADER_DRIVER Kconfig symbol
From: Markos Chandras <Markos.Chandras@imgtec.com>
Date: Mon, 2 Sep 2013 11:11:45 +0100
Cc: <linux-mips@linux-mips.org>
In-reply-to: <52237C76.4010608@phrozen.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1377075213-22398-1-git-send-email-markos.chandras@imgtec.com> <52237C76.4010608@phrozen.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 09/01/13 18:42, John Crispin wrote:
On 21/08/13 10:53, Markos Chandras wrote:
The kbldr.h header file required for this was neither committed in the
original submission in a3a0f8c8ed2e2470f4dcd6da95020d41fed84747
"MIPS: PowerTV: Base files for Cisco PowerTV platform"
nor it was ever present in the git tree so this option never worked.
Fixes the following build problem:
arch/mips/powertv/reset.c:25:36: fatal error:
asm/mach-powertv/kbldr.h: No such
file or directory
compilation terminated.

Signed-off-by: Markos Chandras<markos.chandras@imgtec.com>
Acked-by: Steven J. Hill<Steven.Hill@imgtec.com>
---
This patch is for the upstream-sfr/mips-for-linux-next tree
---
  arch/mips/Kconfig                     |  1 +
  arch/mips/powertv/Kconfig             |  9 +--------
  arch/mips/powertv/asic/asic_devices.c | 15 +++------------
  arch/mips/powertv/init.c              |  4 ----
  arch/mips/powertv/reset.c             | 12 ------------
  5 files changed, 5 insertions(+), 36 deletions(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index e12764c..d08a3a6 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -416,6 +416,7 @@ config PMC_MSP
  config POWERTV
      bool "Cisco PowerTV"
      select BOOT_ELF32
+    select BOOTLOADER_FAMILY
      select CEVT_R4K
      select CPU_MIPSR2_IRQ_VI
      select CPU_MIPSR2_IRQ_EI

Hi,

BOOTLOADER_FAMILY is a string causing the select to spew this error

-> arch/mips/Kconfig:420:warning: 'BOOTLOADER_FAMILY' has wrong type.
'select' only accept arguments of boolean and tristate type

     John

Hi John,

Hmm strange I haven't seen this problem when I tested this patch. I will double check and submit a new patch.


<Prev in Thread] Current Thread [Next in Thread>