linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: ralink: add RESET_CONTROLLER to the defconfig

To: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: ralink: add RESET_CONTROLLER to the defconfig
From: John Crispin <john@phrozen.org>
Date: Sun, 01 Sep 2013 20:48:12 +0200
In-reply-to: <52238B08.3020408@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1378057127-21984-1-git-send-email-blogic@openwrt.org> <52238B08.3020408@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
On 01/09/13 20:44, Gabor Juhos wrote:
2013.09.01. 19:38 keltezéssel, John Crispin írta:
Without this symbol being set, we get an undefined symbol compile error.

The reset framework is unconditionally used by the ralink platform code. So I
assume that the compile error is also present on rt288x, rt3883 and mt7620.

Maybe it would be better to add a 'select RESET_CONTROLLER' for the RALINK
symbol in 'arch/mips/Kconfig'?

BTW, I have looked into your 'MIPS: ralink: add support for reset-controller
API' patch [1] again. That adds a 'select ARCH_HAS_RESET_CONTROLLER' to the
MACH_VR41XX symbol instead of RALINK.


thanks, i will look into it

        John



-Gabor

1. https://patchwork.linux-mips.org/patch/5668/




<Prev in Thread] Current Thread [Next in Thread>