[Top] [All Lists]

Re: [PATCH] MIPS: do not allow building vmlinuz when !ZBOOT

To: Florian Fainelli <>
Subject: Re: [PATCH] MIPS: do not allow building vmlinuz when !ZBOOT
From: James Hogan <>
Date: Thu, 29 Aug 2013 13:54:01 +0100
Cc: <>, <>, <>, <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
Hi Florian,

On 28/08/13 16:42, Florian Fainelli wrote:
>  # boot/compressed
>  vmlinuz vmlinuz.bin vmlinuz.ecoff vmlinuz.srec: $(vmlinux-32) FORCE
>       $(Q)$(MAKE) $(build)=arch/mips/boot/compressed \
>          VMLINUX_LOAD_ADDRESS=$(load-y) 32bit-bfd=$(32bit-bfd) $@
> +else
> +vmlinuz:

Does this need a dependency on FORCE so that if you switched config and
had a valid vmlinuz lying around it doesn't do nothing as a result of
vmlinuz having no dependencies and existing?

> +     @echo '   CONFIG_SYS_SUPPORTS_ZBOOT is not enabled'

Also it may be worth adding false here too so that make's exit code
reports failure correctly.


<Prev in Thread] Current Thread [Next in Thread>