linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: do not allow building vmlinuz when !ZBOOT

To: Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH] MIPS: do not allow building vmlinuz when !ZBOOT
From: James Hogan <james.hogan@imgtec.com>
Date: Thu, 29 Aug 2013 13:54:01 +0100
Cc: <linux-mips@linux-mips.org>, <ralf@linux-mips.org>, <blogic@openwrt.org>, <richard@nod.at>
In-reply-to: <1377704569-21331-1-git-send-email-f.fainelli@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1377704569-21331-1-git-send-email-f.fainelli@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
Hi Florian,

On 28/08/13 16:42, Florian Fainelli wrote:
> +ifdef CONFIG_SYS_SUPPORTS_ZBOOT
>  # boot/compressed
>  vmlinuz vmlinuz.bin vmlinuz.ecoff vmlinuz.srec: $(vmlinux-32) FORCE
>       $(Q)$(MAKE) $(build)=arch/mips/boot/compressed \
>          VMLINUX_LOAD_ADDRESS=$(load-y) 32bit-bfd=$(32bit-bfd) $@
> +else
> +vmlinuz:

Does this need a dependency on FORCE so that if you switched config and
had a valid vmlinuz lying around it doesn't do nothing as a result of
vmlinuz having no dependencies and existing?

> +     @echo '   CONFIG_SYS_SUPPORTS_ZBOOT is not enabled'

Also it may be worth adding false here too so that make's exit code
reports failure correctly.

Cheers
James


<Prev in Thread] Current Thread [Next in Thread>