[Top] [All Lists]

Re: [PATCH v2 2/4] clk: implement clk_unregister

To: Mike Turquette <>
Subject: Re: [PATCH v2 2/4] clk: implement clk_unregister
From: Sylwester Nawrocki <>
Date: Sat, 24 Aug 2013 01:00:53 +0200
Cc: Sylwester Nawrocki <>,,,,,,,,,,,,,,,,,,,
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=6dLE+8S4cohL+yB4BrFuQfjhYrT02HvkR9t66DVsRWk=; b=ryXdN5mf09wA90vSHsWXf1snzoGiKYLVp7kYzP4TW8+t1I+v2Q1+i65vucQBGttcfy vJsh/YDclcOR/P6AbVpciNu7m5GgtATiFmNL66CgIcXlLre7gy81pTIiE+4AxZ8gTPVu LTGcQNhuKf+j5YULXrAjyVPFMTFSYH6Q3RswBRt/SAgxt0+vjZ8guY9HXhw/pM9H8LyE 4QP09I9lK1yvogDzt/jGjxTpm+PGXpT3R3iyaD5LgYUZKgrA53Dq7n8PTAZene66xqkB du+ZFek0YqZh6QrnqaqGside4vyTbQoNkLwl+6z3hvRdX+MyIH95cah5knFhM6LuQPBB BppA==
In-reply-to: <20130823215838.8231.21635@quantum>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <20130823215838.8231.21635@quantum>
User-agent: Mozilla/5.0 (X11; Linux i686; rv:11.0) Gecko/20120412 Thunderbird/11.0.1
On 08/23/2013 11:58 PM, Mike Turquette wrote:
+static void clk_nodrv_disable_unprepare(struct clk_hw *hw)
>  +{
>  +       WARN_ON(1);

Ideally we shouldn't get here, but if we do I guess it could be very
noisy. How about WARN_ONCE?

Yes, I guess that would be much better. I could resend it tomorrow if needed.

After you address Russell's comments in patch #1 I will be happy to take
this series.

I have posted today v3 addressing Russell's comments. Hopefully patch #3
(the patches got reordered) looks OK now. v3 includes actual assigning
of clk->owner I somehow managed to miss in previous series :/ Please have
a look at it.


<Prev in Thread] Current Thread [Next in Thread>