linux-mips
[Top] [All Lists]

Re: [PATCH v2] MIPS: netlogic: xlr: Serial support depends on CONFIG_SER

To: linux-mips@linux-mips.org
Subject: Re: [PATCH v2] MIPS: netlogic: xlr: Serial support depends on CONFIG_SERIAL_8250
From: "Jayachandran C." <jchandra@broadcom.com>
Date: Sun, 18 Aug 2013 15:38:54 +0530
Cc: "Markos Chandras" <markos.chandras@imgtec.com>
In-reply-to: <1376571575-29037-1-git-send-email-markos.chandras@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
> The nlm_early_serial_setup code needs the early_serial_setup symbol
> which is only available if CONFIG_SERIAL_8250 is selected.
> Fixes the following build problem:
> 
> arch/mips/built-in.o: In function `nlm_early_serial_setup':
> setup.c:(.init.text+0x274): undefined reference to `early_serial_setup'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> ---
>  arch/mips/netlogic/xlr/setup.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/mips/netlogic/xlr/setup.c b/arch/mips/netlogic/xlr/setup.c
> index 214d123..6d7d75e 100644
> --- a/arch/mips/netlogic/xlr/setup.c
> +++ b/arch/mips/netlogic/xlr/setup.c
> @@ -60,6 +60,7 @@ unsigned int  nlm_threads_per_core = 1;
>  struct nlm_soc_info nlm_nodes[NLM_NR_NODES];
>  cpumask_t nlm_cpumask = CPU_MASK_CPU0;
> 
> +#ifdef CONFIG_SERIAL_8250
>  static void __init nlm_early_serial_setup(void)
>  {
>         struct uart_port s;
> @@ -78,6 +79,9 @@ static void __init nlm_early_serial_setup(void)
>         s.membase       = (unsigned char __iomem *)uart_base;
>         early_serial_setup(&s);
>  }
> +#else
> +static inline void nlm_early_serial_setup(void) {}
> +#endif
> 

The UART device is on the SoC, so adding 'select SERIAL_8250' to the Kconfig
for NLM_XLP_BOARD may be a better option.

JC.


<Prev in Thread] Current Thread [Next in Thread>