linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: netlogic: xlr: Serial support depends on CONFIG_SERIAL

To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH] MIPS: netlogic: xlr: Serial support depends on CONFIG_SERIAL_8250
From: Markos Chandras <markos.chandras@gmail.com>
Date: Thu, 15 Aug 2013 12:51:55 +0100
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=VVTcedpdEHj26rJzkba0v33Bld+RZr+PiPFrRT1Mj38=; b=vvFHkHusgx1Nf90Un/shaXS/ucuVkPth8BKJ9QT/ljp4DYdPcRk75G1gE+aZn8iYci E85x1lPag9imHqThUOfRKN1mBJ9nakSly2pSrzJwAq6kCYxNCqTOTFWtO0GaFYJnv36s kNZNihX9KRUbACBC+3RNApKW57jfot2k4RbhiITSZwMhCMc2yKxIsA1YXfYZQ5HjCjW0 5dmswxq8ZVslES/GD7VFvnvdh8SvBJhANX5jy2cbjbx2uaYu25TxYtkDcHvTtVrm+0zm Y69IG3h1BzpxytK2pGZZ7HzHghX0l76JvafNpwea2Wh4UICIiyZdOZ6poYAMqnqgi91R LAIA==
In-reply-to: <520CB905.1000700@cogentembedded.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1376555267-1633-1-git-send-email-markos.chandras@imgtec.com> <520CB905.1000700@cogentembedded.com>
Sender: linux-mips-bounce@linux-mips.org
Hi Sergei,

On 15 August 2013 12:18, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
>
>
>    It's better to follow what Documentation/Submitting patches suggest and
> add:
>
> #else
> static inline void nlm_early_serial_setup(void) {}
>
>> +#endif
>>

Thank you for the review. I will submit a new patch.

-- 
Regards,
Markos Chandras

<Prev in Thread] Current Thread [Next in Thread>