linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: add driver for the built-in PCI controller of the RT38

To: James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH] MIPS: add driver for the built-in PCI controller of the RT3883 SoC
From: Gabor Juhos <juhosg@openwrt.org>
Date: Wed, 14 Aug 2013 10:30:30 +0200
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org, John Crispin <blogic@openwrt.org>, devicetree@vger.kernel.org
In-reply-to: <52090650.3000309@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1376064212-28415-1-git-send-email-juhosg@openwrt.org> <52090650.3000309@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
2013.08.12. 17:59 keltezéssel, James Hogan írta:
> On 09/08/13 17:03, Gabor Juhos wrote:
>> +   - status: either "disabled" or "okay"
> 
> Is this really a required property? If it's using the generic code for
> it then I think it will be treated as "okay" if omitted. 

You are right, it is optional. The driver explicitly does not checks the
presence of the property. However instead of removing this part from the doc, I
would change the text to indicate that the property is optional.

> In any case I don't think this property is normally documented in these
> bindings docs (I couldn't find any other instances of it).

It is documented in mvebu-pci.txt as well, at least in 3.11-rc5.

-Gabor


<Prev in Thread] Current Thread [Next in Thread>