linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: remove unnecessary platform dma helper functions

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH 1/2] MIPS: remove unnecessary platform dma helper functions
From: Felix Fietkau <nbd@openwrt.org>
Date: Mon, 12 Aug 2013 19:16:17 +0200
Cc: linux-mips@linux-mips.org
In-reply-to: <5209159D.7040301@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1376306569-83278-1-git-send-email-nbd@openwrt.org> <5209159D.7040301@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
On 2013-08-12 7:04 PM, David Daney wrote:
> That's a mighty thin changelog there.
I thought it was obvious that the lines I removed contain no useful code
at all :)

> You are changing the semantics in the 
> asm/mach-cavium-octeon/dma-coherence.h case.
I'm just removing a fallback BUG() that could never be reached before my
change either. As for the other platforms, I verified that there's no
useful code in these functions anywhere in the tree.

> Have you verified that all in-tree cases really are NOPs?
Yes.

- Felix


<Prev in Thread] Current Thread [Next in Thread>