linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: partially inline dma ops

To: Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH 2/2] MIPS: partially inline dma ops
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 12 Aug 2013 10:08:47 -0700
Cc: linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=lYnXa9ZsUfWTk2lqck+YkXj/eXaXNZYLtec1XMZIsxE=; b=h3YC0zZwojArpuSWgwwfIPDzk5XpF4WZJHxhJWMe8EY7x8iHBDRb2SdbPFauhQsMAX hmKstlCpPrpk8Vp+gdw8g5TNlk7nZimEaot9JU7ipAChZbRa4KYRKpVFTiSBYBGIzp2e O/yQYbevL1hg6AraHNBJtRcjnflUYeBGMVmPQ3TBofh6kE6PM4Emqs9B7OrJHqCPhPrr R2ykBFMUnH4KHs1HEVAPeGhe/W+vw8fMVfH4Y0M8+MmTY4vmHmbY5ANKdvz1nqwn7Xp9 q6DT7pdm47uFtsTU6cRLrZxynaMcQ4oF/gpy797wLwtrK/kO/y2L4R7IRWUn15Kw1efv chSw==
In-reply-to: <1376306569-83278-2-git-send-email-nbd@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1376306569-83278-1-git-send-email-nbd@openwrt.org> <1376306569-83278-2-git-send-email-nbd@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 08/12/2013 04:22 AM, Felix Fietkau wrote:
Several DMA ops are no-op on many platforms, and the indirection through
the mips_dma_map_ops function table is causing the compiler to emit
unnecessary code.

Inlining visibly improves network performance in my tests (on a 24Kc
based system), and also slightly reduces code size of a few drivers.

Signed-off-by: Felix Fietkau <nbd@openwrt.org>
---
  arch/mips/Kconfig                   |   4 +
  arch/mips/include/asm/dma-mapping.h | 360 +++++++++++++++++++++++++++++++++++-
  arch/mips/mm/dma-default.c          | 161 ++--------------
  3 files changed, 372 insertions(+), 153 deletions(-)


That is not a very pleasing diffstat.


David

<Prev in Thread] Current Thread [Next in Thread>