linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] SPI: ralink: add Ralink SoC spi driver

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 2/2] SPI: ralink: add Ralink SoC spi driver
From: James Hogan <james.hogan@imgtec.com>
Date: Mon, 12 Aug 2013 17:10:05 +0100
Cc: Mark Brown <broonie@kernel.org>, Gabor Juhos <juhosg@openwrt.org>, <linux-spi@vger.kernel.org>, <linux-mips@linux-mips.org>
In-reply-to: <1376074288-29302-2-git-send-email-blogic@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1376074288-29302-1-git-send-email-blogic@openwrt.org> <1376074288-29302-2-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 09/08/13 19:51, John Crispin wrote:
> +#ifdef DEBUG
> +#define spi_debug(args...) printk(args)
> +#else
> +#define spi_debug(args...)
> +#endif

This looks a bit like pr_debug. If you have a device pointer around,
there's also a dev_dbg which takes an additional device pointer and
prepends it's name to the message.

> +static int rt2880_spi_probe(struct platform_device *pdev)
> +{

<snip>

> +     clk = devm_clk_get(&pdev->dev, NULL);
> +     if (IS_ERR(clk)) {
> +             dev_err(&pdev->dev, "unable to get SYS clock, err=%d\n",
> +                     status);
> +             return PTR_ERR(clk);
> +     }

<snip>

> +}
> +
> +static int rt2880_spi_remove(struct platform_device *pdev)
> +{
> +     struct spi_master *master;
> +     struct rt2880_spi *rs;
> +
> +     master = dev_get_drvdata(&pdev->dev);
> +     rs = spi_master_get_devdata(master);
> +
> +     clk_disable(rs->clk);
> +     clk_put(rs->clk);

The devm_clk_get in your probe function means you don't need clk_put here.

Cheers
James


<Prev in Thread] Current Thread [Next in Thread>