linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] DT: Add documentation for spi-rt2880

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 1/2] DT: Add documentation for spi-rt2880
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Date: Sat, 10 Aug 2013 00:44:26 +0400
Cc: Mark Brown <broonie@kernel.org>, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, linux-mips@linux-mips.org
In-reply-to: <1376074288-29302-1-git-send-email-blogic@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Organization: Cogent Embedded
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1376074288-29302-1-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
Hello.

On 08/09/2013 10:51 PM, John Crispin wrote:

Describe the SPI master found on the MIPS based Ralink SoC.

Signed-off-by: John Crispin <blogic@openwrt.org>
Cc: devicetree@vger.kernel.org
Cc: linux-spi@vger.kernel.org
Cc: linux-mips@linux-mips.org
---
  .../devicetree/bindings/spi/spi-rt2880.txt         |   26 ++++++++++++++++++++
  1 file changed, 26 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/spi/spi-rt2880.txt

diff --git a/Documentation/devicetree/bindings/spi/spi-rt2880.txt 
b/Documentation/devicetree/bindings/spi/spi-rt2880.txt
new file mode 100644
index 0000000..d946626
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/spi-rt2880.txt
@@ -0,0 +1,26 @@
+Ralink SoC RT2880 and famile SPI master controller.
+
+Required properties:
+- compatible : "ralink,rt2880-spi"
+- reg : The register base for the controller.
+- #address-cells : <1>, as required by generic SPI binding.
+- #size-cells : <0>, also as required by generic SPI binding.
+
+Child nodes as per the generic SPI binding.
+
+Example:
+
+       spi@b00 {
+               compatible = "ralink,rt2880-spi";
+               reg = <0xb00 0x100>;
+
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               m25p80@0 {

Don't call nodes with chip names. ePAPR [1] says: "the name of a node should be somewhat generic, reflecting the function of the device and not its precise programming model". I suspect this is a flash device, ePAPR suggests using "flash" as a name in this case.

+                       compatible = "m25p80";
+                       reg = <0>;
+                       spi-max-frequency = <10000000>;
+               };
+       };
+

WBR, Sergei


<Prev in Thread] Current Thread [Next in Thread>