linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] serial: MIPS: lantiq: add clk_enable() call to driver

To: James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH 1/2] serial: MIPS: lantiq: add clk_enable() call to driver
From: John Crispin <blogic@openwrt.org>
Date: Thu, 08 Aug 2013 16:56:51 +0200
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-serial@vger.kernel.org, linux-mips@linux-mips.org, Thomas Langer <thomas.langer@lantiq.com>
In-reply-to: <5203AF83.30101@imgtec.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1375968687-8704-1-git-send-email-blogic@openwrt.org> <5203AF83.30101@imgtec.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
On 08/08/13 16:47, James Hogan wrote:
On 08/08/13 14:31, John Crispin wrote:
From: Thomas Langer<thomas.langer@lantiq.com>

Enable the clock if one is present when setting up the console.

Signed-off-by: Thomas Langer<thomas.langer@lantiq.com>
Acked-by: John Crispin<blogic@openwrt.org>
---
  drivers/tty/serial/lantiq.c |    3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c
index 15733da..ce1ea35 100644
--- a/drivers/tty/serial/lantiq.c
+++ b/drivers/tty/serial/lantiq.c
@@ -636,6 +636,9 @@ lqasc_console_setup(struct console *co, char *options)

        port =&ltq_port->port;

+       if (ltq_port->clk)
I think that should be !IS_ERR(ltq_port->clk)? The same problem appears
to be elsewhere in that file too.

Cheers
James




Thanks, i will send an updated series


<Prev in Thread] Current Thread [Next in Thread>