linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] serial: MIPS: lantiq: make driver use pinctrl

To: John Crispin <blogic@openwrt.org>
Subject: Re: [PATCH 2/2] serial: MIPS: lantiq: make driver use pinctrl
From: James Hogan <james.hogan@imgtec.com>
Date: Thu, 8 Aug 2013 15:50:08 +0100
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, <linux-serial@vger.kernel.org>, <linux-mips@linux-mips.org>, Thomas Langer <thomas.langer@lantiq.com>
In-reply-to: <1375968687-8704-2-git-send-email-blogic@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1375968687-8704-1-git-send-email-blogic@openwrt.org> <1375968687-8704-2-git-send-email-blogic@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
On 08/08/13 14:31, John Crispin wrote:
> From: Thomas Langer <thomas.langer@lantiq.com>
> 
> Add use of devm_pinctrl_get_select_default to active default pinctrl settings.
> 
> Signed-off-by: Thomas Langer <thomas.langer@lantiq.com>
> Acked-by: John Crispin <blogic@openwrt.org>
> ---
>  drivers/tty/serial/lantiq.c |    7 +++++++
>  1 file changed, 7 insertions(+)


> @@ -719,6 +722,10 @@ lqasc_probe(struct platform_device *pdev)
>       port->irq       = irqres[0].start;
>       port->mapbase   = mmres->start;
>  
> +     pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> +     if (IS_ERR(pinctrl))
> +             dev_warn(&pdev->dev, "pins are not configured from the 
> driver\n");

I believe since v3.9 (specifically commit ab78029) this happens
automatically.

Cheers
James


<Prev in Thread] Current Thread [Next in Thread>