linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: add proper set_mode() to cevt-r4k

To: David Daney <ddaney.cavm@gmail.com>
Subject: Re: [PATCH] MIPS: add proper set_mode() to cevt-r4k
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 31 Jul 2013 20:26:02 +0100
Cc: John Crispin <john@phrozen.org>, Linux-MIPS <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding:content-type; bh=E38yIpHMuGTajVVJXrSdFpidfP2iOvaz4LAXL6esRDg=; b=a0tkqISZNIZKxrahocAv4KVxe8bGDsNxhK98q4RGENKcicWIHALgo3IKdrpayX870e rhLXO+hS1rSHGg6Yl60EuaiuOBsOYm2amA1JW6zW2x7rywLQZ1MVMkOISQBzJryuJrlA LDyul9EhZya5joru5yCIQlgB3o+oawVg42qc+LqZTOK8PXArSRC2UafYJn0LHqrknWxT FKlfmp48nS2B7XlzOqrGq6+xgwZGo27lAba+XshvibkpiqHoZoXFRmnnmidxtEi/2RpC H25VqmKxQxuG3KQuixGewFK3NOyq+W5nMbGp/tekd5WLhk2SIm6PmsjFUZRP46IWeCPF ClTQ==
In-reply-to: <51F963E7.50407@gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1375091743-20608-1-git-send-email-blogic@openwrt.org> <CAGVrzcYcP8kUueLkDtL+fT9g+HFUKGgdw_hTRXkhA8P+4LbL8A@mail.gmail.com> <51F963E7.50407@gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: KMail/4.10.5 (Linux/3.8.0-27-generic; KDE/4.10.5; x86_64; ; )
Le mercredi 31 juillet 2013 12:22:15 David Daney a écrit :
> On 07/29/2013 04:14 AM, Florian Fainelli wrote:
> > 2013/7/29 John Crispin <john@phrozen.org>:
> [...]
> 
> >>> It looks to me like you are moving the irq setup later just to ensure
> >>> that your ralink clockevent device has been registered before and has
> >>> set cp0_timer_irq_installed when the set_mode() r4k clockevent device
> >>> runs, such that it won't register the same IRQ that your platforms
> >>> uses. If that it the case, cannot you just ensure that you run your
> >>> cevt device registration before mips_clockevent_init() is called?
> >> 
> >> i dont like relying on the order in which the modules get loaded.
> > 
> > plat_time_init() runs before mips_clockevent_init() and the ordering
> > is explicit, would not that work for what you are trying to do?
> > 
> >> the actual problem is not the irq sharing but that the cevt-r4k registers
> >> the irq when the cevt is registered and not when it is activated. i
> >> believe
> >> that the patch fixes this problem
> > 
> > Your patch certainly does what you say it does, but that is kind of an
> > abuse of the set_mode() callback.
> 
> I might as add my $0.02...
> 
> There are many other clockevent drivers that do this type of thing
> aren't there?  The clockevent framework uses this to
> install/remove/switch drivers, so why should cevt-r4k not be made to
> work like this?

Whatever works for you. I still would like to understand why plat_time_init() 
is not suitable for John's specific use case.
-- 
Florian

<Prev in Thread] Current Thread [Next in Thread>