linux-mips
[Top] [All Lists]

Re: [PATCH 1/2] MIPS: tlbex: Fix typo in r3000 tlb store handler

To: "Tony Wu" <tung7970@gmail.com>
Subject: Re: [PATCH 1/2] MIPS: tlbex: Fix typo in r3000 tlb store handler
From: "Jayachandran C." <jchandra@broadcom.com>
Date: Thu, 18 Jul 2013 12:11:07 +0530
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20130717175840-tung7970@googlemail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20130717175840-tung7970@googlemail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 17, 2013 at 05:59:47PM +0800, Tony Wu wrote:
> Should test against handle_tlbs_end, not handle_tlbs.
> 
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Jayachandran C <jchandra@broadcom.com>
> ---
>  arch/mips/mm/tlbex.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
> index 9ab0f90..605b6fc 100644
> --- a/arch/mips/mm/tlbex.c
> +++ b/arch/mips/mm/tlbex.c
> @@ -1803,7 +1803,7 @@ static void __cpuinit 
> build_r3000_tlb_store_handler(void)
>       uasm_i_j(&p, (unsigned long)tlb_do_page_fault_1 & 0x0fffffff);
>       uasm_i_nop(&p);
>  
> -     if (p >= handle_tlbs)
> +     if (p >= handle_tlbs_end)
>               panic("TLB store handler fastpath space exceeded");
>  
>       uasm_resolve_relocs(relocs, labels);

Thanks for fixing this.

Acked-by: Jayachandran C. <jchandra@broadcom.com>

You should add the commit which caused the trouble to the commit message,
like:

commit 6ba045f (MIPS: Move generated code to .text for microMIPS) causes
a panic at boot.

JC.


<Prev in Thread] Current Thread [Next in Thread>