linux-mips
[Top] [All Lists]

Re: [PATCH 2/2] MIPS: tlbex: Guard tlbmiss_handler_setup_pgd

To: "Tony Wu" <tung7970@gmail.com>
Subject: Re: [PATCH 2/2] MIPS: tlbex: Guard tlbmiss_handler_setup_pgd
From: "Jayachandran C." <jchandra@broadcom.com>
Date: Thu, 18 Jul 2013 12:23:30 +0530
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org
In-reply-to: <20130717180052-tung7970@googlemail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <20130717175840-tung7970@googlemail.com> <20130717180052-tung7970@googlemail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Jul 17, 2013 at 06:01:29PM +0800, Tony Wu wrote:
> tlbmiss_handler_setup_pgd* are only referenced when
> CONFIG_MIPS_PGD_C0_CONTEXT is defined.
> 
> Signed-off-by: Tony Wu <tung7970@gmail.com>
> Cc: Jayachandran C <jchandra@broadcom.com>
> ---
>  arch/mips/mm/tlb-funcs.S |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/mm/tlb-funcs.S b/arch/mips/mm/tlb-funcs.S
> index 30a494d..79bca31 100644
> --- a/arch/mips/mm/tlb-funcs.S
> +++ b/arch/mips/mm/tlb-funcs.S
> @@ -16,10 +16,12 @@
>  
>  #define FASTPATH_SIZE        128
>  
> +#ifdef CONFIG_MIPS_PGD_C0_CONTEXT
>  LEAF(tlbmiss_handler_setup_pgd)
>       .space          16 * 4
>  END(tlbmiss_handler_setup_pgd)
>  EXPORT(tlbmiss_handler_setup_pgd_end)
> +#endif
>  
>  LEAF(handle_tlbm)
>       .space          FASTPATH_SIZE * 4

There is a patchset planned which uses tlbmiss_handler_setup_pgd when
CONFIG_MIPS_PGD_C0_CONTEXT is not defined, but it did not make it into 3.11.

This change can be applied - but if it goes in, I will need to undo this
as part of the scratch patchset.

JC.


<Prev in Thread] Current Thread [Next in Thread>