linux-mips
[Top] [All Lists]

Re: [PATCH 05/10] MIPS: bmips: merge CPU options into one option

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH 05/10] MIPS: bmips: merge CPU options into one option
From: Jonas Gorski <jogo@openwrt.org>
Date: Tue, 16 Jul 2013 14:41:45 +0200
Cc: Linux-MIPS <linux-mips@linux-mips.org>, Ralf Baechle <ralf@linux-mips.org>, John Crispin <blogic@openwrt.org>, Maxime Bizon <mbizon@freebox.fr>, Kevin Cernekee <cernekee@gmail.com>
In-reply-to: <CAGVrzcYsJrohQBoDG+TP6aXJcQ2b4Gb8JrLFnBM7uYTHycWF4Q@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1372537073-27370-1-git-send-email-jogo@openwrt.org> <1372537073-27370-6-git-send-email-jogo@openwrt.org> <CAGVrzcYsJrohQBoDG+TP6aXJcQ2b4Gb8JrLFnBM7uYTHycWF4Q@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
On Tue, Jul 16, 2013 at 2:31 PM, Florian Fainelli <florian@openwrt.org> wrote:
> Hello Jonas,
>
> 2013/6/29 Jonas Gorski <jogo@openwrt.org>:
> [snip]
>
>> +config CPU_BMIPS
>> +       bool "Broadcom BMIPS"
>> +       depends on SYS_HAS_CPU_BMIPS
>> +       select CPU_MIPS32
>> +       select CPU_BMIPS3300 if SYS_HAS_CPU_BMIPS3300
>> +       select CPU_BMIPS4350 if SYS_HAS_CPU_BMIPS4350
>> +       select CPU_BMIPS4350 if SYS_HAS_CPU_BMIPS4380
>
> As you already made me notice privately, this should be:
>
> select CPU_BMIPS4380 if SYS_HAS_CPU_BMIPS4380

I'm currently preparing a V2 that will fix this, the missed squash
commit message in 6/10, and adds bcm47xx bmips selection (so that
Ralf's cputype patch won't break bcm47xx and bcm63xx anymore). I
marked the patches in patchwork accordingly.


Jonas

<Prev in Thread] Current Thread [Next in Thread>