[Top] [All Lists]

Re: [PATCH V10 12/13] MIPS: Loongson 3: Add CPU hotplug support

To: Huacai Chen <>
Subject: Re: [PATCH V10 12/13] MIPS: Loongson 3: Add CPU hotplug support
From: Fuxin Zhang <>
Date: Thu, 11 Jul 2013 20:35:19 +0800
Cc: Ralf Baechle <>, John Crispin <>,, Zhangjin Wu <>, Hongliang Tao <>, Hua Yan <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <> <> <>
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
于 2013/7/11 17:31, Huacai Chen 写道:
Normal labels and nops can be removed, but loongson3_play_dead()
should be run at CKSEG0, I'm afraid that it will have a wrong behavior
if I write it with C.
I think just replacing flush_loop with number label like 1: will be ok. Don't think too much.

On Fri, Jun 28, 2013 at 3:08 PM, Ralf Baechle <> wrote:
On Fri, Jun 28, 2013 at 09:05:53AM +0200, Ralf Baechle wrote:

+           "flush_loop:                             \n" /* flush L1 */
Please don't use normale in inline assembler.  This might result in build
errors.  it's horrible to read but number local labels like:
That was meant to read "Please don't use normal labels" in inline assembler.


总经理 张福新

<Prev in Thread] Current Thread [Next in Thread>