linux-mips
[Top] [All Lists]

Re: [PATCH V10 12/13] MIPS: Loongson 3: Add CPU hotplug support

To: Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH V10 12/13] MIPS: Loongson 3: Add CPU hotplug support
From: Fuxin Zhang <zhangfx@lemote.com>
Date: Thu, 11 Jul 2013 20:35:19 +0800
Cc: Ralf Baechle <ralf@linux-mips.org>, John Crispin <john@phrozen.org>, linux-mips@linux-mips.org, Zhangjin Wu <wuzhangjin@gmail.com>, Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>
In-reply-to: <CAAhV-H4m5c++fFTtr9kd294MXtRH-DwTMmXP2Ds7w+6S==jorw@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1366030028-5084-1-git-send-email-chenhc@lemote.com> <1366030028-5084-13-git-send-email-chenhc@lemote.com> <20130628070553.GI10727@linux-mips.org> <20130628070829.GJ10727@linux-mips.org> <CAAhV-H4m5c++fFTtr9kd294MXtRH-DwTMmXP2Ds7w+6S==jorw@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
于 2013/7/11 17:31, Huacai Chen 写道:
Normal labels and nops can be removed, but loongson3_play_dead()
should be run at CKSEG0, I'm afraid that it will have a wrong behavior
if I write it with C.
I think just replacing flush_loop with number label like 1: will be ok. Don't think too much.

On Fri, Jun 28, 2013 at 3:08 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
On Fri, Jun 28, 2013 at 09:05:53AM +0200, Ralf Baechle wrote:

+           "flush_loop:                             \n" /* flush L1 */
Please don't use normale in inline assembler.  This might result in build
errors.  it's horrible to read but number local labels like:
That was meant to read "Please don't use normal labels" in inline assembler.

   Ralf



--
江苏中科梦兰电子科技有限公司
总经理 张福新
zhangfx@lemote.com


<Prev in Thread] Current Thread [Next in Thread>