linux-mips
[Top] [All Lists]

Re: [PATCH V10 12/13] MIPS: Loongson 3: Add CPU hotplug support

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH V10 12/13] MIPS: Loongson 3: Add CPU hotplug support
From: Huacai Chen <chenhc@lemote.com>
Date: Thu, 11 Jul 2013 17:31:58 +0800
Cc: John Crispin <john@phrozen.org>, linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>, Zhangjin Wu <wuzhangjin@gmail.com>, Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=B8+9cOeZ1wAZ5i59esQ3jDFF4jPQvUMXkv/lLEewQAc=; b=Kb2WLPZGFoYLBU/r7JyUiEZaeaxcECVreg7O7Ze3nrXSf8SEC0n3Q4ni+Q08UqOBqC SxP3iSvIhxcB95fPxqpMV5tgdQCU19s1OfelaDHEseksvTxSis8kisGNYbOqp5hdMiEc 4rYZE5FumLTKes0hBBiYLdMHVbJ5dUUtiSCiSGeQ4j90IoZ60UTe3Ua0SRfyCmj9McC2 6GAB6PwBH3tTJHJjETPdi1lbfSSb+GvRtmu9xZIUggqG9x6hJ/6H2eQSbkU8B7eSq70R oSihE+wI2Pahu+PmwLPz6UkQEmSE9d0XsYkDXGSsPHXTXnSMwETnXqxRUr6BtydXYLyd FUEQ==
In-reply-to: <20130628070829.GJ10727@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1366030028-5084-1-git-send-email-chenhc@lemote.com> <1366030028-5084-13-git-send-email-chenhc@lemote.com> <20130628070553.GI10727@linux-mips.org> <20130628070829.GJ10727@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
Normal labels and nops can be removed, but loongson3_play_dead()
should be run at CKSEG0, I'm afraid that it will have a wrong behavior
if I write it with C.

On Fri, Jun 28, 2013 at 3:08 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Fri, Jun 28, 2013 at 09:05:53AM +0200, Ralf Baechle wrote:
>
>> > +           "flush_loop:                             \n" /* flush L1 */
>>
>> Please don't use normale in inline assembler.  This might result in build
>> errors.  it's horrible to read but number local labels like:
>
> That was meant to read "Please don't use normal labels" in inline assembler.
>
>   Ralf
>

<Prev in Thread] Current Thread [Next in Thread>