linux-mips
[Top] [All Lists]

Re: [PATCH v2] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PH

To: Markos Chandras <markos.chandras@gmail.com>
Subject: Re: [PATCH v2] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PHYS_OFFSET"
From: "Steven J. Hill" <Steven.Hill@imgtec.com>
Date: Wed, 3 Jul 2013 10:56:24 -0500
Cc: Ralf Baechle <ralf@linux-mips.org>, <linux-mips@linux-mips.org>, "Leonid Yegoshin" <Leonid.Yegoshin@imgtec.com>, Florian Fainelli <florian@openwrt.org>
In-reply-to: <CAG2jQ8gf+0rmO-JynMGUUw7evAU2eG5JdWG7+rT58ATDfCFRVQ@mail.gmail.com>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1371742590-10138-1-git-send-email-Steven.Hill@imgtec.com> <20130626145234.GB7171@linux-mips.org> <CAG2jQ8gf+0rmO-JynMGUUw7evAU2eG5JdWG7+rT58ATDfCFRVQ@mail.gmail.com>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6
On 07/03/2013 09:01 AM, Markos Chandras wrote:

I am afraid this commit[1] broke the build in
upstream-sfr/mips-for-linux-next with errors like this

arch/mips/include/asm/mach-generic/spaces.h:29:0: warning:
"UNCAC_BASE" redefined [enabled by default]
In file included from arch/mips/include/asm/addrspace.h:13:0,
                  from arch/mips/include/asm/barrier.h:11,
                  from arch/mips/include/asm/bitops.h:18,
                  from include/linux/bitops.h:22,
                  from include/linux/kernel.h:10,
                  from include/asm-generic/bug.h:13,
                  from arch/mips/include/asm/bug.h:41,
                  from include/linux/bug.h:4,
                  from include/linux/page-flags.h:9,
                  from kernel/bounds.c:9:
arch/mips/include/asm/mach-ar7/spaces.h:20:0: note: this is the
location of the previous definition

[1]: 
http://git.linux-mips.org/?p=ralf/upstream-sfr.git;a=commit;h=ed3ce16c3d2ba7cac321d29ec0a7d21408ea8437

Let me rebase the patch and send another version.



<Prev in Thread] Current Thread [Next in Thread>