[Top] [All Lists]

Re: [PATCH v2] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PH

To: Markos Chandras <>
Subject: Re: [PATCH v2] Revert "MIPS: make CAC_ADDR and UNCAC_ADDR account for PHYS_OFFSET"
From: "Steven J. Hill" <>
Date: Wed, 3 Jul 2013 10:56:24 -0500
Cc: Ralf Baechle <>, <>, "Leonid Yegoshin" <>, Florian Fainelli <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6
On 07/03/2013 09:01 AM, Markos Chandras wrote:

I am afraid this commit[1] broke the build in
upstream-sfr/mips-for-linux-next with errors like this

arch/mips/include/asm/mach-generic/spaces.h:29:0: warning:
"UNCAC_BASE" redefined [enabled by default]
In file included from arch/mips/include/asm/addrspace.h:13:0,
                  from arch/mips/include/asm/barrier.h:11,
                  from arch/mips/include/asm/bitops.h:18,
                  from include/linux/bitops.h:22,
                  from include/linux/kernel.h:10,
                  from include/asm-generic/bug.h:13,
                  from arch/mips/include/asm/bug.h:41,
                  from include/linux/bug.h:4,
                  from include/linux/page-flags.h:9,
                  from kernel/bounds.c:9:
arch/mips/include/asm/mach-ar7/spaces.h:20:0: note: this is the
location of the previous definition


Let me rebase the patch and send another version.

<Prev in Thread] Current Thread [Next in Thread>