[Top] [All Lists]

Re: [PATCH] MIPS: bcm63xx: clk: Add dummy clk_set_rate() function

To: Lars-Peter Clausen <>
Subject: Re: [PATCH] MIPS: bcm63xx: clk: Add dummy clk_set_rate() function
From: Markos Chandras <>
Date: Mon, 1 Jul 2013 14:06:06 +0100
Cc: <>
In-reply-to: <>
List-archive: <>
List-help: <>
List-id: linux-mips <>
List-owner: <>
List-post: <>
List-software: Ecartis version 1.0.0
List-subscribe: <>
List-unsubscribe: <>
Original-recipient: rfc822;
References: <> <>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6
On 07/01/13 12:06, Lars-Peter Clausen wrote:
On 07/01/2013 12:57 PM, Markos Chandras wrote:
Several drivers use the clk_set_rate() function that needs
to be defined in the platform's clock code. The Broadcom
BCM63xx platform hardcodes the clock rate so we create a new
dummy clk_set_rate() function which just returns -EINVAL.

Also fixes the following build problem on a randconfig:
drivers/built-in.o: In function `nop_usb_xceiv_probe':
phy-nop.c:(.text+0x3ec26c): undefined reference to `clk_set_rate'

Signed-off-by: Markos Chandras <>
Acked-by: Steven J. Hill <>

To make the set complete clk_round_rate() should be added as well

This patch is for the upstream-sfr/mips-for-linux-next tree
  arch/mips/bcm63xx/clk.c | 6 ++++++
  1 file changed, 6 insertions(+)

diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
index c726a97..70dcc52 100644
--- a/arch/mips/bcm63xx/clk.c
+++ b/arch/mips/bcm63xx/clk.c
@@ -318,6 +318,12 @@ unsigned long clk_get_rate(struct clk *clk)


+int clk_set_rate(struct clk *clk, unsigned long rate)
+       return -EINVAL;
  struct clk *clk_get(struct device *dev, const char *id)
        if (!strcmp(id, "enet0"))

Hi Lars,

Thanks. I will submit a new patch

<Prev in Thread] Current Thread [Next in Thread>