linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER
From: Florian Fainelli <florian@openwrt.org>
Date: Fri, 28 Jun 2013 14:40:17 +0100
Cc: Markos Chandras <markos.chandras@imgtec.com>, Linux-MIPS <linux-mips@linux-mips.org>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=HfyUjYMIEuvRhric117STtezZK3wfYPleUkoxdJKQvQ=; b=CwhFGTHnEYg2xMI0h6RjFcOj6BKQaR82qJNPBW+8hW6h7xvCJZ4SoYoISvHTei9yjR zgVg5TZWSSDjzS9sD5qwVdfx5vztDWMmlrgf76/WrHZt1vmvRgDeg1ocQzmoEE7l99HO vcCihOlZB/1JMH+CXV1CKlPlBhTNrf0GSWdUNwQvu8RJxVRNQUvHJ09C4iBLg9mIBB5F 3w7WhjBfVOFKSpFCWPO8bTCum054BM3aHSlOnNpi4oHnuw2sQCvJHhv/fV3ICx7BZHKw vFr8PTXGR0iQejlT88o1svRjxQRme3XAO3tuTfVMLnPF+jscom/XcLQHDStcwWMGwxO2 9y1w==
In-reply-to: <20130628133111.GN10727@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1372422327-21814-1-git-send-email-markos.chandras@imgtec.com> <20130628133111.GN10727@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
2013/6/28 Ralf Baechle <ralf@linux-mips.org>:
> On Fri, Jun 28, 2013 at 01:25:27PM +0100, Markos Chandras wrote:
>
>> The vpe.c code uses the 'struct module' which is only available if
>> CONFIG_MODULES is selected.
>>
>> Also fixes the following build problem on a lantiq allmodconfig:
>> In file included from arch/mips/kernel/vpe.c:41:0:
>> include/linux/moduleloader.h: In function 'apply_relocate':
>> include/linux/moduleloader.h:48:63: error: dereferencing pointer
>> to incomplete type
>> include/linux/moduleloader.h: In function 'apply_relocate_add':
>> include/linux/moduleloader.h:70:63: error: dereferencing pointer
>> to incomplete type
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Reviewed-by: James Hogan <james.hogan@imgtec.com>
>
> Sigh.  One more bug in the thing.  It first of all shouldn't have been
> designed recycling so much code from the module loader in inapropriate
> ways.
>
> I'm going to apply the patch - but as usual whenver I have to touch the
> VPE loader, kspd or rtlx I feel like a blunt chainsaw would be the right
> way to fix this code.
>
> SPUFS is a special filesystem which was designed to use the Playstation 3's
> synergetic elements.  The code is in arch/powerpc/platforms/cell/spufs
> and it's a far, cleaner interface to other processing thingies, be they
> synergetic elements, or other cores, VPEs and TCs running bare metal
> code or strage things like custom processors.

Would not remoteproc be a simpler interface these days to load
bare-metal ELF code into one of these things?
--
Florian

<Prev in Thread] Current Thread [Next in Thread>