linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: BMIPS: fix warnings for non BMIPS43xx builds

To: Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: BMIPS: fix warnings for non BMIPS43xx builds
From: Florian Fainelli <florian@openwrt.org>
Date: Thu, 27 Jun 2013 12:17:59 +0100
Cc: Linux-MIPS <linux-mips@linux-mips.org>, John Crispin <blogic@openwrt.org>, jogo@openwrt.org, Kevin Cernekee <cernekee@gmail.com>
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=pIna/cN1rVdHdQkjBVSCchzVSSaBAPtBzVyvvrn9/gk=; b=AiwlEA1OxkyMmM4g+dOXytH/2aNcuNXq4lkm0Q+lYLUNJWxtAZ25M41JVdHrGVjL0L 1xql1h698oadROeEw4jsH34+irw+H/3OR7YOxUewltcjAHpFtcRU8GfdQ34WUhWIkyxk 1K4ShxUobN1Jbdi2Pz98ngLNhnfIvyS4/3zSovI5x8SIqu3o/WmcwMiFGRs1HYYJVX4y 7nR29zGKY+BTsLEXM6XE7E+LZc0nm94SayGBVcOy3UtRuP+nG3rqsue8VUrmwlh/uc46 COTVqgNSDlhlCmZmPks8UZZkqvAZUEQEmWlueqSnz/1wj3kKPSojLd0kZSjtI1olul0n W6bQ==
In-reply-to: <20130627111116.GT7171@linux-mips.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1372329915-17944-1-git-send-email-florian@openwrt.org> <20130627111116.GT7171@linux-mips.org>
Sender: linux-mips-bounce@linux-mips.org
2013/6/27 Ralf Baechle <ralf@linux-mips.org>:
> On Thu, Jun 27, 2013 at 11:45:15AM +0100, Florian Fainelli wrote:
>
>> Commit dccfb4c4 ("MIPS: BMIPS: support booting from physical CPU other
>> than 0") introduces the following warning when building for non
>> BMIPS43xx builds:
>>
>> arch/mips/kernel/smp-bmips.c:150:6: error: unused variable 'tpid'
>> [-Werror=unused-variable]
>>
>> Fix this by getting rid of this variable and directly using
>> cpu_logical_map(cpu).
>
> Sounds like the previous patch wasn't really tested - or somebody shot
> himself into the foot by removing the -Werror.

There is nothing in tree using BMIPS3300 or BMIPS5000 which are the
only two other possibilities where this warning could have been
caught.

>
> Anyway, folded in.

Thanks
--
Florian

<Prev in Thread] Current Thread [Next in Thread>