linux-mips
[Top] [All Lists]

Re: [PATCH] MIPS: BMIPS: fix warnings for non BMIPS43xx builds

To: Florian Fainelli <florian@openwrt.org>
Subject: Re: [PATCH] MIPS: BMIPS: fix warnings for non BMIPS43xx builds
From: Ralf Baechle <ralf@linux-mips.org>
Date: Thu, 27 Jun 2013 13:11:16 +0200
Cc: linux-mips@linux-mips.org, blogic@openwrt.org, jogo@openwrt.org, cernekee@gmail.com
In-reply-to: <1372329915-17944-1-git-send-email-florian@openwrt.org>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1372329915-17944-1-git-send-email-florian@openwrt.org>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Jun 27, 2013 at 11:45:15AM +0100, Florian Fainelli wrote:

> Commit dccfb4c4 ("MIPS: BMIPS: support booting from physical CPU other
> than 0") introduces the following warning when building for non
> BMIPS43xx builds:
> 
> arch/mips/kernel/smp-bmips.c:150:6: error: unused variable 'tpid'
> [-Werror=unused-variable]
> 
> Fix this by getting rid of this variable and directly using
> cpu_logical_map(cpu).

Sounds like the previous patch wasn't really tested - or somebody shot
himself into the foot by removing the -Werror.

Anyway, folded in.

  Ralf

<Prev in Thread] Current Thread [Next in Thread>