linux-mips
[Top] [All Lists]

Re: [PATCH v2 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown

To: Aaro Koskinen <aaro.koskinen@iki.fi>
Subject: Re: [PATCH v2 1/2] MIPS: cavium-octeon: cvmx-helper-board: print unknown board warning only once
From: David Daney <ddaney.cavm@gmail.com>
Date: Mon, 24 Jun 2013 15:33:36 -0700
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=TGqCh+Vo8VIIp0hWB/n+VVAHD4NuvTg1XJMKvUGhoIs=; b=ZO3Xxu/pOC66NyktZpxR4I/40elIPMlnIRV+qA/zvHCWykeYMNzDPwkDMG19kjehkI M7x5mOucdeTj/Msv/0Qc+5hGM7OyOd/I+FvYJXHtgZv8xiZexs0X2LXTC+c0fvIubndM pIPSr+opcA1Q0LWnXFTZFz2GEX/udFPi11hK93/Ei81aFks5hnMa7T++AtN00q6PKE6v hsKyiQSBDGz2AjaJCDPTUaOXZ4oGHm3nJ6TOcqEbNxp151m0G367MKzI1XK1+IHNhqRH tILJASAdEU7Gey61ktXOB96kBBE2HGA6dTiF5G9kcc1qCovkRVXRIOXJ7Q2f92k7ftuk h6ew==
In-reply-to: <20130624220429.GB20703@blackmetal.musicnaut.iki.fi>
List-archive: <http://www.linux-mips.org/archives/linux-mips/>
List-help: <mailto:ecartis@linux-mips.org?Subject=help>
List-id: linux-mips <linux-mips.eddie.linux-mips.org>
List-owner: <mailto:ralf@linux-mips.org>
List-post: <mailto:linux-mips@linux-mips.org>
List-software: Ecartis version 1.0.0
List-subscribe: <mailto:ecartis@linux-mips.org?subject=subscribe%20linux-mips>
List-unsubscribe: <mailto:ecartis@linux-mips.org?subject=unsubscribe%20linux-mips>
Original-recipient: rfc822;linux-mips@linux-mips.org
References: <1372023524-17333-1-git-send-email-aaro.koskinen@iki.fi> <51C89567.3000108@gmail.com> <20130624220429.GB20703@blackmetal.musicnaut.iki.fi>
Sender: linux-mips-bounce@linux-mips.org
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6
On 06/24/2013 03:04 PM, Aaro Koskinen wrote:
On Mon, Jun 24, 2013 at 11:52:23AM -0700, David Daney wrote:
On 06/23/2013 02:38 PM, Aaro Koskinen wrote:
When booting a new board for the first time, the console is flooded with
"Unknown board" messages. This is not really helpful. Board type is not
going to change after the boot, so it's sufficient to print the warning
only once.

Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>

I don't think we need this patch.  In 2/2 you add the board type for
the board you have, so you shouldn't be getting any messages, and
this is unneeded.

I don't mind spamming people with all the messages,  if people see
these messages, they have bigger problems than too many messages.

I guess this patch can be dropped, but whoever tries to improve the
support for the next new Octeon board will get annoyed by these same
messages...

I would hope that the "next new Octeon board" would have a bootloader that supplies a device tree. That way most of this would never be used, and there would be no messages.

David Daney



<Prev in Thread] Current Thread [Next in Thread>